Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create rc pull request when the default branch proceeded #2

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Conversation

Songmu
Copy link
Owner

@Songmu Songmu commented Aug 14, 2022

No description provided.

if c.err != nil {
return c.err
}
remote, _, err := git("remote", "-v")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <SA4006> reported by reviewdog 🐶
this value of err is never used

rcpr.go Outdated
}
owner := m[1]
repo := m[2]
strings.TrimSuffix(repo, ".git") // XXX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <SA4017> reported by reviewdog 🐶
TrimSuffix is a pure function but its return value is ignored

@Songmu Songmu merged commit 0e69c70 into main Aug 14, 2022
@Songmu Songmu deleted the create-pr branch August 14, 2022 19:03
This was referenced Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant